This repository was archived by the owner on May 8, 2026. It is now read-only.
fix: fix regression in batch#close silently ignoring entry failures by upgrading to gax to 1.50.0 - #67
Merged
Conversation
1 task
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage 81.29% 81.29%
Complexity 937 937
=========================================
Files 95 95
Lines 5842 5842
Branches 325 325
=========================================
Hits 4749 4749
Misses 917 917
Partials 176 176Continue to review full report at Codecov.
|
igorbernstein2
approved these changes
Nov 6, 2019
igorbernstein2
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but is there any way to make this prominent in the changelog. I would like something like "Fix regression of Batcher.close() failing silently"
…y upgrading to gax to 1.50.0
kolea2
force-pushed
the
gax-update-1.50.0
branch
from
November 6, 2019 19:48
689a5fb to
6424447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.