Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: Prevent integration tests from different profiles from clobbering each other - #69

Merged
kolea2 merged 1 commit into
googleapis:masterfrom
igorbernstein2:it-fixes
Nov 7, 2019
Merged

fix: Prevent integration tests from different profiles from clobbering each other#69
kolea2 merged 1 commit into
googleapis:masterfrom
igorbernstein2:it-fixes

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

The integration tests in this project can target multiple environments: emulator, cloud, etc. This is implemented using profiles. To avoid conflicts, the summary reports were suffixed by the profile name. Unfortunately the individual test reports were not and each profile would overwrite the previous reports. This PR gives each profile its own directory.

Also, it fixes up the setup script

@igorbernstein2 igorbernstein2 added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Nov 6, 2019
@igorbernstein2
igorbernstein2 requested a review from kolea2 November 6, 2019 22:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2019
@codecov

codecov Bot commented Nov 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity      937      937           
=========================================
  Files            95       95           
  Lines          5842     5842           
  Branches        325      325           
=========================================
  Hits           4749     4749           
  Misses          917      917           
  Partials        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa8769...32c0626. Read the comment docs.

@kolea2
kolea2 merged commit 638615a into googleapis:master Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants