Enable mocking of functional classes and configurations by mziccard · Pull Request #892 · googleapis/google-cloud-java

mziccard · 2016-04-11T15:57:25Z

This PR removes final from functional classes definition and configurations. For those classes this also adds final to equals and hashCode methods if not present. equals and hashCode are updated to avoid issue #890.

Sign in to view

+  public final boolean equals(Object obj) {
+    return this == obj
+        || obj instanceof LoadJobConfiguration
+        && baseEquals((LoadJobConfiguration) obj);


aozarov · 2016-04-11T20:11:35Z

cleanup looks fine, however I wonder if we can make it more consistent.
Feel free to merge if you think otherwise or that it should be done in a different PR.

coveralls · 2016-04-12T11:42:58Z

Coverage increased (+0.01%) to 85.583% when pulling 54e4f58 on mziccard:mock-functional into de23a12 on GoogleCloudPlatform:master.

mziccard · 2016-04-12T11:43:19Z

@aozarov I had to rebase to trigger CI. I added one more commit that does a better job in making equals and hashCode consistent across all modules. Please have a look.

coveralls · 2016-04-12T20:16:05Z

Changes Unknown when pulling bd53cca on mziccard:mock-functional into * on GoogleCloudPlatform:master*.

Sign in to view

 * existing table. Copy job configurations have {@link JobConfiguration.Type#COPY} type.
 */
-public final class CopyJobConfiguration extends JobConfiguration {
+public class CopyJobConfiguration extends JobConfiguration {


ajkannan · 2016-04-13T21:55:53Z

Finished my pass. Once you've addressed the comments and fixed the merge conflicts, feel free to merge.

coveralls · 2016-04-14T15:00:31Z

Coverage increased (+0.01%) to 85.583% when pulling 5adf431 on mziccard:mock-functional into 13ab36f on GoogleCloudPlatform:master.

mziccard · 2016-04-14T15:03:11Z

Had to rebase to fix conflicts and trigger travis. Comments fixed in 5adf431

ajkannan · 2016-04-14T22:19:52Z

LGTM

… v1beta1 batch_prediction_job.proto (#892) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 456339444 Source-Link: googleapis/googleapis@3b9c451 Source-Link: https://github.com/googleapis/googleapis-gen/commit/95a293beab5db62d3c734b083550e0ab446a9ad3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTVhMjkzYmVhYjVkYjYyZDNjNzM0YjA4MzU1MGUwYWI0NDZhOWFkMyJ9 feat: add model_version_id to UploadModelResponse in aiplatform v1 model_service.proto PiperOrigin-RevId: 455486702 Source-Link: googleapis/googleapis@f2e5538 Source-Link: https://github.com/googleapis/googleapis-gen/commit/15200223b157cb9e76c7923bc387dd6e9c0a83bd Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTUyMDAyMjNiMTU3Y2I5ZTc2Yzc5MjNiYzM4N2RkNmU5YzBhODNiZCJ9 feat: add default_skew_threshold to TrainingPredictionSkewDetectionConfig in aiplatform v1beta1, v1 model_monitoring.proto feat: add default_drift_threshold to PredictionDriftDetectionConfig in aiplatform v1beta1, v1 model_monitoring.proto PiperOrigin-RevId: 455164942 Source-Link: googleapis/googleapis@db1cd5e Source-Link: https://github.com/googleapis/googleapis-gen/commit/47772101d683e45375539ffcdee797f78fe608cb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDc3NzIxMDFkNjgzZTQ1Mzc1NTM5ZmZjZGVlNzk3Zjc4ZmU2MDhjYiJ9 chore: Integrate new gapic-generator-java and rules_gapic PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9 feat: add successful_forecast_point_count to CompletionStats in aiplatform v1 completion_stats.proto feat: add neighbors to Explanation in aiplatform v1 explanation.proto feat: add examples_override to ExplanationSpecOverride in aiplatform v1 explanation.proto feat: add version_id, version_aliases, version_create_time, version_update_time, and version_description to aiplatform v1 model.proto feat: add ModelVersion CRUD methods in aiplatform v1 model_service.proto feat: add model_id and parent_model to TrainingPipeline in aiplatform v1 training_pipeline.proto PiperOrigin-RevId: 453734478 Source-Link: googleapis/googleapis@84720fb Source-Link: https://github.com/googleapis/googleapis-gen/commit/93ace7716e168e3c2cba123bce51a5362a39429c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTNhY2U3NzE2ZTE2OGUzYzJjYmExMjNiY2U1MWE1MzYyYTM5NDI5YyJ9 feat: add env to ContainerSpec in aiplatform v1beta1 custom_job.proto PiperOrigin-RevId: 453732998 Source-Link: googleapis/googleapis@a95a55f Source-Link: https://github.com/googleapis/googleapis-gen/commit/e2ea25266cc6608d2180843dde9051b4ba37cd9b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTJlYTI1MjY2Y2M2NjA4ZDIxODA4NDNkZGU5MDUxYjRiYTM3Y2Q5YiJ9 feat: add monitor_window to ModelDeploymentMonitoringScheduleConfig proto in aiplatform v1/v1beta1 model_deployment_monitoring_job.proto PiperOrigin-RevId: 453226330 Source-Link: googleapis/googleapis@239db5e Source-Link: https://github.com/googleapis/googleapis-gen/commit/4cf0c542505025be51be9e67120f0413415e7d67 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNmMGM1NDI1MDUwMjViZTUxYmU5ZTY3MTIwZjA0MTM0MTVlN2Q2NyJ9 feat: add IAM policy to aiplatform_v1beta1.yaml feat: add preset configuration for example-based explanations in aiplatform v1beta1 explanation.proto feat: add latent_space_source to ExplanationMetadata in aiplatform v1beta1 explanation_metadata.proto feat: add successful_forecast_point_count to CompletionStats in completion_stats.proto PiperOrigin-RevId: 450727462 Source-Link: googleapis/googleapis@665682d Source-Link: https://github.com/googleapis/googleapis-gen/commit/34cddbef39c17c58f96f5ffebf6065136b6d5719 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzRjZGRiZWYzOWMxN2M1OGY5NmY1ZmZlYmY2MDY1MTM2YjZkNTcxOSJ9 feat: add failure_policy to PipelineJob in aiplatform v1 & v1beta1 pipeline_job.proto PiperOrigin-RevId: 450704795 Source-Link: googleapis/googleapis@c875f2b Source-Link: https://github.com/googleapis/googleapis-gen/commit/e606d62ab32b85434697678b3004f2206d5c02ae Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTYwNmQ2MmFiMzJiODU0MzQ2OTc2NzhiMzAwNGYyMjA2ZDVjMDJhZSJ9 feat: add latent_space_source to ExplanationMetadata in aiplatform v1 explanation_metadata.proto feat: add scaling to OnlineServingConfig in aiplatform v1 featurestore.proto feat: add template_metadata to PipelineJob in aiplatform v1 pipeline_job.proto PiperOrigin-RevId: 450687287 Source-Link: googleapis/googleapis@058bff3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/f072bfe7704d996c41d74ac3aa1d8514f464c4ff Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjA3MmJmZTc3MDRkOTk2YzQxZDc0YWMzYWExZDg1MTRmNDY0YzRmZiJ9 chore(deps): upgrade gapic-generator-java to 2.8.0 and update gax-java to 2.18.1 PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9 feat: add Examples to Explanation related messages in aiplatform v1beta1 explanation.proto PiperOrigin-RevId: 449620845 Source-Link: googleapis/googleapis@117f86b Source-Link: https://github.com/googleapis/googleapis-gen/commit/1d670dbb1a9ff155cf686e9544feffb75021a2f5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWQ2NzBkYmIxYTlmZjE1NWNmNjg2ZTk1NDRmZWZmYjc1MDIxYTJmNSJ9 Synchronize new proto/yaml changes. PiperOrigin-RevId: 449052112 Source-Link: googleapis/googleapis@3150afa Source-Link: https://github.com/googleapis/googleapis-gen/commit/9945a366e4a5efb00fc40985f03c107bdee89df2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTk0NWEzNjZlNGE1ZWZiMDBmYzQwOTg1ZjAzYzEwN2JkZWU4OWRmMiJ9 feat: add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto PiperOrigin-RevId: 448160148 Source-Link: googleapis/googleapis@936ab35 Source-Link: https://github.com/googleapis/googleapis-gen/commit/f841b8e23d816e998f9e8e6c0e04ba92b7f6b835 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjg0MWI4ZTIzZDgxNmU5OThmOWU4ZTZjMGUwNGJhOTJiN2Y2YjgzNSJ9 fix!: added packaging options for C#, Ruby, and PHP PiperOrigin-RevId: 448116670 Source-Link: googleapis/googleapis@914bc52 Source-Link: https://github.com/googleapis/googleapis-gen/commit/db499206c1ede59f599ca2b05699e86bd4ee152e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI0OTkyMDZjMWVkZTU5ZjU5OWNhMmIwNTY5OWU4NmJkNGVlMTUyZSJ9 feat: add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto PiperOrigin-RevId: 447082691 Source-Link: googleapis/googleapis@02b3022 Source-Link: https://github.com/googleapis/googleapis-gen/commit/753e1acf0deda59bc451482e6278c7dab4908b9c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzUzZTFhY2YwZGVkYTU5YmM0NTE0ODJlNjI3OGM3ZGFiNDkwOGI5YyJ9 chore(deps): upgrade gapic-generator-java to 2.7.0 and update gax-java to 2.16.0 PiperOrigin-RevId: 446250659 Source-Link: googleapis/googleapis@dc4ef31 Source-Link: https://github.com/googleapis/googleapis-gen/commit/5fdda4ddfbab87998e77e4a453e0ff87986d2db8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWZkZGE0ZGRmYmFiODc5OThlNzdlNGE0NTNlMGZmODc5ODZkMmRiOCJ9

mziccard added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern. labels Apr 11, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 11, 2016

aozarov reviewed Apr 11, 2016
View reviewed changes

Comment thread gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/LoadJobConfiguration.java

public final boolean equals(Object obj) {

return this == obj

|| obj instanceof LoadJobConfiguration

&& baseEquals((LoadJobConfiguration) obj);

This comment was marked as spam.

Sign in to view

mziccard force-pushed the mock-functional branch from 9b154a0 to 54e4f58 Compare April 12, 2016 11:37

mziccard force-pushed the mock-functional branch from 54e4f58 to bd53cca Compare April 12, 2016 20:10

ajkannan reviewed Apr 13, 2016
View reviewed changes

mziccard added 3 commits April 14, 2016 16:48

Enable mocking of functional classes and configurations

214dc78

Refactor classes to be either final or have final equals/hashCode

e4165c2

Make job configuration classes final

5adf431

mziccard force-pushed the mock-functional branch from d1d3463 to 5adf431 Compare April 14, 2016 14:55

ajkannan merged commit 7d7b799 into googleapis:master Apr 14, 2016

mziccard mentioned this pull request Apr 15, 2016

StackOverflowError mocking our functional objects #890

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable mocking of functional classes and configurations - #892

Enable mocking of functional classes and configurations#892
ajkannan merged 3 commits into
googleapis:masterfrom
mziccard:mock-functional

mziccard commented Apr 11, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 11, 2016

Uh oh!

coveralls commented Apr 12, 2016

Uh oh!

mziccard commented Apr 12, 2016

Uh oh!

coveralls commented Apr 12, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Apr 13, 2016

Uh oh!

coveralls commented Apr 14, 2016

Uh oh!

mziccard commented Apr 14, 2016

Uh oh!

ajkannan commented Apr 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

mziccard commented Apr 11, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 11, 2016

Uh oh!

coveralls commented Apr 12, 2016

Uh oh!

mziccard commented Apr 12, 2016

Uh oh!

coveralls commented Apr 12, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Apr 13, 2016

Uh oh!

coveralls commented Apr 14, 2016

Uh oh!

mziccard commented Apr 14, 2016

Uh oh!

ajkannan commented Apr 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants